Fix user-defined donation prices being saved with zero value

[shanebrowncs]

Hi,

After updating my alf.io instance from 2.0-M4-2304 to 2.0-M4-2402-3 I noticed donation fields with user-defined pricing no longer work properly.

Here is an example of a ticket which costs $5.50 with an attached donation of $7.00:

When I reach the summary screen you can see the donation value in the table is $0.00:

Upon investigating I found this is being caused by the incorrect field being inserted into additional_service_item.src_price_cts. When the event/{eventName}/reserve-tickets endpoint is called, eventually we get to the 'AdditionalServiceManager.bookAdditionalServiceItems' method where we are inserting the additional_service_item rows to the database. For the src_price_cts column we are inserting as.getSrcPriceCts() which when the price is NOT fixed has a value of 0. When calling 'AdditionalServicePriceContainer.getSrcPriceCts' it already has it's own method of dealing with this issue by checking whether the price is fixed:

    @Override
    public int getSrcPriceCts() {
        if(additionalService.isFixPrice()) {
            return additionalService.getSrcPriceCts();
        }
        return Optional.ofNullable(customAmount).map(a -> MonetaryUtil.unitToCents(a, currencyCode)).orElse(0);
    }

Because of this it seemed appropriate to just substitute the call to as.getSrcPriceCts() with pc.getSrcPriceCts(). If you could please let me know if this is something you would be interested in merging. I am not very familiar with the codebase but would be happy to look at implementing further required changes if necessary.

Thank you.

[syjer]

Hi @shanebrowncs , thank you for noticing and opening a PR.

If it's possible, could you also add a test? (My guess a unit test would be enough)

[shanebrowncs]

Hi @syjer, I have added an additional commit with a new unit test file for AdditionalServiceManager. It tests both main code paths in bookAdditionalServiceItems(). Please let me know if this is acceptable.

Is there any chance this could be included in a patch release? I already have upgraded my instance to 2.0-M4-2402-3 and rely on this feature.

Thank you.

[syjer]

hi @shanebrowncs , everything looks fine, thank you for the PR! We will merge it, cherry pick on the m4 branch and do a patch release.

[shanebrowncs]

Great, thank you!

[cbellone]

merged. Thank you!