Detect Cancel Pending Reservation Event in extension_log

[MarkBis415]

Modify ReservationFlowIntegrationTest to assert that the RESERVATION_CANCELLED event is fired when calling reservationApiV2Controller.cancelPendingReservation.
This requires the following to occur:

1. Add the Extension.js to src/test/resources/
2. Generate the script

• As soon as the test starts, prepare the environment by inserting the extension.js to the database
• Insert as async = true and async = false

3. Check that the particular event has been fired

• We would expect that the corresponding event and only this event logged is RESERVATION_CANCELLED

TODO: 4. Clear the extension log table

• Use the Spring jdbcTemplate update() method to issue a SQL statement similar to: TRUNCATE TABLE table_name;
• The table is called extension_log

Current behavior
Presence of RESERVATION_CANCELLED log has been asserted. Also, there are always eight rows in the log when we insert two extensions (one async and one sync). The test still fails due to the following:

19:56:45.789 [Test worker] WARN  alfio.extension.ScriptingExecutionService - hello from script with event: EVENT_CREATED
19:56:45.883 [pool-4-thread-1] WARN  alfio.extension.ScriptingExecutionService - Was not able to compile script asyncName
org.springframework.dao.EmptyResultDataAccessException: Incorrect result size: expected 1, actual 0
…
19:56:46.816 [Test worker] WARN  alfio.extension.ScriptingExecutionService - hello from script with event: EVENT_STATUS_CHANGE
19:56:46.830 [pool-4-thread-1] WARN  alfio.extension.ScriptingExecutionService - Was not able to compile script asyncName
org.springframework.dao.EmptyResultDataAccessException: Incorrect result size: expected 1, actual 0
…
19:56:48.825 [Test worker] WARN  alfio.extension.ScriptingExecutionService - hello from script with event: RESERVATION_VALIDATION
19:56:48.825 [Test worker] WARN  alfio.extension.ScriptingExecutionService - Error while executing script syncName:
com.google.gson.JsonSyntaxException: java.lang.IllegalStateException: Expected BEGIN_OBJECT but was STRING at line 1 column 1 path $

On track to close #873.
Contributors: @MarkBis415, @rmace001, @YeeitsAlex

[YeeitsAlex]

Cannot test “cancel pending reservation” because of limitations in the test with running asynchronous extension services. Instead, we have successfully tested an “event created” log, which is a synchronous extension. The next step is to run asynchronous extensions as synchronous during testing. This pull request is ready for review.

[cbellone]

There is a small error in the extension script (we forgot to cover one case) which is preventing the tests to pass.
Once this small issue is fixed we can merge the pull request

Great Job! Thanks for your contribution!

[cbellone]

The test is currently failing because we forgot to add here a "return null;" statement to cover all the other Sync events (like RESERVATION_VALIDATION) that expect the script to return something. So this should be:

function executeScript(scriptEvent) {
    log.warn('hello from script with event: ' + scriptEvent);
    extensionLogger.logInfo(scriptEvent);//logs into the extension_log table
    if(scriptEvent === 'INVOICE_GENERATION') {
        return {
            invoiceNumber: 'blabla'
        };
    }
    return null;
}

instead

[cbellone]

merged. Thanks! 👍