Nitpick CI test #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -241,6 +241,14 @@ public function testGetId() | |||
| $this->assertEquals('azure', $oTheme->getId()); | |||
| } | |||
|
|
|||
| public function testGetSettings(){ | |||
There was a problem hiding this comment.
- Expected
function abc(...); foundfunction abc(...) - Expected 1 space after FUNCTION keyword; 3 found
- Opening brace should be on a new line
alfredbez
force-pushed
the
feature-readSettingsFromTheme
branch
2 times, most recently
from
cbfc44c
to
ad4afeb
Compare
alfredbez
pushed a commit
that referenced
this pull request
Sep 29, 2016
Category tree, selected category search fix
alfredbez
pushed a commit
that referenced
this pull request
Mar 28, 2017
alfredbez
pushed a commit
that referenced
this pull request
Mar 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.