tests: use absolute import for fake_module #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewschoen
reviewed
Jul 3, 2017
remoto/tests/test_connection.py
Outdated
| @@ -2,7 +2,7 @@ | |||
| from mock import Mock, patch | |||
| from py.test import raises | |||
| from remoto import connection | |||
| import fake_module | |||
| import remoto.tests.fake_module as fake_module | |||
There was a problem hiding this comment.
I think from . import fake_module might be nicer here.
There was a problem hiding this comment.
Thanks! That works for me. Re-pushed.
Prior to this change, Python 3 raised an ImportError on the relative import here. Switch to an absolute import to resolve this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, Python 3 raised an
ImportErroron the relative import here. Switch to an absolute import to resolve this.