feat: explicitly set base of server-reflexive addresses
#455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. I need to circle back to this later this week. Did a mega-deploy at work today, so it's been busy. |
No worries at all. If you want to see how it is used, check the linked PR :) |
github-merge-queue bot
pushed a commit
to firezone/firezone
that referenced
this pull request
Jan 31, 2024
…ckets (#3411) It turns out that we need to do some post-processing of the `Transmit.source` attribute from `str0m`. In its current state, `str0m` may also set that to a server-reflexive address which is **not** a local socket. There is a longer discussion around this here: algesten/str0m#453. This depends on an unmerged PR in `str0m`: algesten/str0m#455.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without further adjustments, this will set
Transmit.sourceto the provided base here. Opening this here because we are (temporarily) depending on it.Resolves: #453.