feat(ice): make timeout values configurable #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
algesten
approved these changes
Jul 5, 2024
thomaseizinger
force-pushed
the
feat/ice-timeout-configurable
branch
from
e44188a
to
b040e68
Compare
thomaseizinger
force-pushed
the
feat/ice-timeout-configurable
branch
from
b040e68
to
74c5b31
Compare
|
Should this be available in RtcConfig as well? (I know we want tune some of these values) |
Yeah. Let's make a follow up PR since Thomas doesn't use Rtc. |
github-merge-queue bot
pushed a commit
to firezone/firezone
that referenced
this pull request
Aug 2, 2024
With the adoption of #5080, connlib is now resilient against temporarily failed connections as they'll be immediately re-established. Thus, we no longer need any of the patches that we are currently maintaining in our str0m fork. The only difference is an adjustment of the ICE timeout parameters but those can be made configurable in str0m. Related: algesten/str0m#537.
github-merge-queue bot
pushed a commit
to firezone/firezone
that referenced
this pull request
Aug 2, 2024
With the adoption of #5080, connlib is now resilient against temporarily failed connections as they'll be immediately re-established. Thus, we no longer need any of the patches that we are currently maintaining in our str0m fork. The only difference is an adjustment of the ICE timeout parameters but those can be made configurable in str0m. Related: algesten/str0m#537.
github-merge-queue bot
pushed a commit
to firezone/firezone
that referenced
this pull request
Aug 2, 2024
With the adoption of #5080, connlib is now resilient against temporarily failed connections as they'll be immediately re-established. Thus, we no longer need any of the patches that we are currently maintaining in our str0m fork. The only difference is an adjustment of the ICE timeout parameters but those can be made configurable in str0m. Related: algesten/str0m#537.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the 3 components that make up the ICE timeout configurable. I tried to add some documentation to the setters to the best of my understanding of how this works internally.
Resolves: #490.