Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tagging releases on GitHub #72

Closed
jsha opened this issue Jun 20, 2020 · 5 comments
Closed

Tagging releases on GitHub #72

jsha opened this issue Jun 20, 2020 · 5 comments

Comments

@jsha
Copy link
Collaborator

jsha commented Jun 20, 2020

While working on a documentation issue, I tried to check out an earlier version of ureq (v1.1.2), but I found that there are no tagged releases in this repo. Would you be willing to start git tag'ing releases? There's some discussion about using git tag for crate releases at https://users.rust-lang.org/t/psa-please-git-tag-your-crates-io-releases/22223/10.

@algesten
Copy link
Owner

@jsha sure!

At this point, I was going to ask whether we are should cut a new release – so many improvements!

I just invited you as collaborator.

Instead of me asking you what the plan is, it's better you drive as you see fit. When you think we should release, you can make a tag yourself (cargo bump is nice, which can also automatically do the git commit), ping me and I'll publish it.

I'm very happy to discuss and feedback on PRs, so I don't mean I will be any less involved.

@jsha
Copy link
Collaborator Author

jsha commented Jun 21, 2020

Thanks for the trust! I think it's probably time for a new release soon, but there are a few more tweaks I'd like to land first (will file some issues shortly).

My default assumption is that as a collaborator I will send PRs for every change I originate, even e.g. adding a git commit to bump the version in Cargo.toml. Let me know if you'd like me to modify that default.

@jsha jsha closed this as completed Jun 21, 2020
@algesten
Copy link
Owner

@jsha Sounds good! Since I've alone in managing releases and ensuring the stability, I've allowed myself to push to master. But I'm totally happy to stop that and originate any change I want as PR as well.

So let's PR version bumps too!

@jsha
Copy link
Collaborator Author

jsha commented Jun 22, 2020

#80 and #81 are the ones I would like to land before the next version bump. Once those are landed, I think the bundle of changes will be a nice overall improvement to the connection pooling capabilities.

@lolgesten
Copy link
Contributor

Very solid improvement!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants