Allow TLS client config to be overridden #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidiw
reviewed
May 20, 2020
|
@algesten anyway we could get this into crates.io? We're likely going to have to patch this in in the meantime. |
|
@davidiw hey! I've been busy with some work stuff. I'll check the PR now. |
|
Pushed in 1.1.0 |
|
Thank you so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: ClientConfig
Addresses: #37
I am adding this so that I can provide a client certificate. However providing a custom
ClientConfigallows for changing a lot more, such as custom trust anchors.I have done the integration testing with https://badssl.com to avoid having to spin up a TLS terminating server locally, hope that's ok.