rustls default to ring backend #753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
algesten
force-pushed
the
fix/rustls-default-to-ring
branch
from
b7d92d1
to
76e3ae5
Compare
|
Thanks for this! I would like to see this change in the release. When is this planned to be merged? |
I think I can merge and release this weekend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rustls 0.23 changes the default crypto backend from ring to aws-lc-rs.
aws-lc-rs has some additional build requirements like
cmakeandnasmon windows.ureq will use feature flags to enable ring until such time rustls
builds more easily out-of-the-box with default features.
Related to #751
Related recommendation for using Ring instead of rustls default: rustls/rustls#1913 (comment)