Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(googlepubsub): check if the subscription is attached to the topic #496

Merged
merged 2 commits into from
Jul 31, 2023

Conversation

ccoeurderoy
Copy link
Collaborator

Description

  • Check that if the subscription has already been created with the topic previously (autoCreate mode disabled), the subscription is attached to the provided topic.

Motivation and Context

When a topic and a subscription have been created before calling the listen method, no error is thrown if the subscription has nothing to do with the topic. It does not block the listen method, but creates inconsistency

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@ccoeurderoy ccoeurderoy marked this pull request as ready for review July 31, 2023 15:09
@ccoeurderoy ccoeurderoy merged commit 57ddbee into algoan:master Jul 31, 2023
4 checks passed
@ccoeurderoy ccoeurderoy deleted the fix/sub-attachment branch July 31, 2023 15:09
@algoanbot
Copy link

🎉 This PR is included in version 5.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants