fix(types): union SearchForFacetValuesResponse type for multipleQueri…

…es (#1460) * fix(types): union SearchForFacetValuesResponse type for multipleQueries * fix(tests): account for new type in multiple-operations test
algolia · Jun 19, 2023 · 6a786f1 · 6a786f1
1 parent 9092414
commit 6a786f1
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/packages/client-search/src/__tests__/integration/multiple-operations.test.ts b/packages/client-search/src/__tests__/integration/multiple-operations.test.ts
@@ -1,6 +1,12 @@
 import { BatchActionEnum, StrategyEnum } from '../..';
 import { TestSuite } from '../../../../client-common/src/__tests__/TestSuite';
-import { MultipleBatchRequest } from '../../types';
+import { MultipleBatchRequest, MultipleQueriesResponse, SearchResponse } from '../../types';
+
+function expectSearchResponse<TObject>(
+  results: MultipleQueriesResponse<TObject>['results'][number]
+): asserts results is SearchResponse<TObject> {
+  expect(results).toHaveProperty('hits');
+}
 
 const testSuite = new TestSuite('multiple_operations');
 
@@ -62,7 +68,9 @@ test(testSuite.testName, async () => {
     { strategy: StrategyEnum.None }
   );
 
+  expectSearchResponse(multipleQueriesResponse1.results[0]);
   expect(multipleQueriesResponse1.results[0].hits).toHaveLength(2);
+  expectSearchResponse(multipleQueriesResponse1.results[1]);
   expect(multipleQueriesResponse1.results[1].hits).toHaveLength(2);
 
   const multipleQueriesResponse2 = await client.search(
@@ -73,7 +81,9 @@ test(testSuite.testName, async () => {
     { strategy: StrategyEnum.StopIfEnoughMatches }
   );
 
+  expectSearchResponse(multipleQueriesResponse2.results[0]);
   expect(multipleQueriesResponse2.results[0].hits).toHaveLength(2);
+  expectSearchResponse(multipleQueriesResponse2.results[1]);
   expect(multipleQueriesResponse2.results[1].hits).toHaveLength(0);
 
   const searchForFacetValuesResponse = await client.searchForFacetValues([

diff --git a/packages/client-search/src/types/MultipleQueriesResponse.ts b/packages/client-search/src/types/MultipleQueriesResponse.ts
@@ -1,8 +1,8 @@
-import { SearchResponse } from '.';
+import { SearchForFacetValuesResponse, SearchResponse } from '.';
 
 export type MultipleQueriesResponse<TObject> = {
   /**
    * The list of results.
    */
-  results: Array<SearchResponse<TObject>>;
+  results: Array<SearchResponse<TObject> | SearchForFacetValuesResponse>;
 };