Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(api-keys): fix typing issues #1270

Merged
merged 2 commits into from Apr 29, 2021
Merged

fix(api-keys): fix typing issues #1270

merged 2 commits into from Apr 29, 2021

Conversation

kombucha
Copy link
Contributor

@kombucha kombucha commented Apr 28, 2021 •
edited

  • createdAt is a unix timestamp when using listApiKeys or getApiKey, not a string
  • UpdateApiKeyOptions is missing the acl attribute (See documentation)

@kombucha kombucha added the TypeScript Problems related to TypeScript definitions label Apr 28, 2021
@kombucha kombucha self-assigned this Apr 28, 2021
@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 28, 2021 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7adea8d:

Sandbox Source
javascript-client-app Configuration

@kombucha kombucha changed the title fix(api-keys): fix GetApiKeyResponse createdAt attribute typing fix(api-keys): fix typing issues Apr 28, 2021
Haroenv
Haroenv approved these changes Apr 29, 2021
View reviewed changes
Copy link
Contributor

@Haroenv Haroenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@Haroenv Haroenv merged commit fec87a9 into master Apr 29, 2021
@Haroenv Haroenv deleted the fix-api-key-response-type branch April 29, 2021 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Haroenv Haroenv Haroenv approved these changes

Assignees

@kombucha kombucha

Labels
TypeScript Problems related to TypeScript definitions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kombucha @Haroenv