Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: makes node entry point es6 compliant #1005

Merged
merged 2 commits into from Feb 12, 2020
Merged

Conversation

@nunomaduro
Copy link
Member

nunomaduro commented Feb 11, 2020

This pull request fixes #1000 - avoiding users to use esModuleInterop key to use our common js node entry point.

@nunomaduro nunomaduro requested review from yannickcr, chloelbn and Haroenv Feb 11, 2020
@nunomaduro nunomaduro merged commit 76aa7b3 into master Feb 12, 2020
8 of 11 checks passed
8 of 11 checks passed
ci/circleci: test_unit-4 Your tests failed on CircleCI
Details
ci/circleci: test_browser CircleCI is running your tests
Details
ci/circleci: test_build CircleCI is running your tests
Details
Semantic Pull Request ready to be squashed
Details
ci/circleci: test_lint Your tests passed on CircleCI!
Details
ci/circleci: test_types Your tests passed on CircleCI!
Details
ci/circleci: test_unit-1 Your tests passed on CircleCI!
Details
ci/circleci: test_unit-2 Your tests passed on CircleCI!
Details
ci/circleci: test_unit-3 Your tests passed on CircleCI!
Details
ci/circleci: test_unit-5 Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@nunomaduro nunomaduro deleted the feat/node-es6-compliance branch Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.