Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rules-filter-promotes): adds field to rule type #1013

Merged
merged 2 commits into from
Feb 21, 2020
Merged

feat(rules-filter-promotes): adds field to rule type #1013

merged 2 commits into from
Feb 21, 2020

Conversation

nunomaduro
Copy link

Adds type filterPromotes to rule.

@nunomaduro nunomaduro self-assigned this Feb 14, 2020
@Haroenv
Copy link
Contributor

Haroenv commented Feb 14, 2020

can we add docs links to those types?

Haroenv
Haroenv approved these changes Feb 14, 2020
View reviewed changes
Copy link
Contributor

@Haroenv Haroenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks correct according to https://www.algolia.com/doc/api-reference/api-parameters/filterPromotes/

@nunomaduro
Copy link
Author

@Haroenv I don't find elegant have types with links inside of it. Let's discuss it later, and do a pull request adding links everywhere.

@Haroenv
Copy link
Contributor

Haroenv commented Feb 17, 2020

this worked ok https://github.com/DefinitelyTyped/DefinitelyTyped/blob/f2db20ef615bd88a605a9b8750ec8ba170e2415a/types/algoliasearch/index.d.ts#L1213

@nunomaduro nunomaduro merged commit 724dde4 into master Feb 21, 2020
@nunomaduro nunomaduro deleted the feat/adds-filter-promotes branch February 21, 2020 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Haroenv Haroenv Haroenv approved these changes

@chloelbn chloelbn Awaiting requested review from chloelbn

Assignees

@nunomaduro nunomaduro

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nunomaduro @Haroenv