fix: header field x-algolia-user-id is not allowed by access-control-allow-headers #1023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Haroenv
reviewed
Feb 19, 2020
Haroenv
approved these changes
Feb 20, 2020
aseure
approved these changes
Feb 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multi-cluster methods using
x-algolia-user-idheader onPOST|DELETEverbs may encounter the bugheader field x-algolia-user-id is not allowed by access-control-allow-headerswhile using this methods on the browser.This PR fixes that exact same issue passing
x-algolia-user-idon the query parameter instead of the browser.In addition, we also increase the timeouts of the transporter layer to avoid flakiness, and we did reactivate the mcm test now that the mcm cluster is alive again.