feat(browse): make shouldStop public on the browsable methods #1029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Haroenv
commented
Feb 20, 2020
nunomaduro
changed the title
|
Let's keep this on hold. |
|
In progress, going to expose a |
Haroenv
commented
Jun 2, 2020
Haroenv
changed the title
nunomaduro
force-pushed
the
feat/browse-should
branch
from
ef75c62
to
f7f4d33
Compare
This isn't necessarily the best solution here, but the idea is to browse, but being able to stop based on your own condition (e.g. hits reaching a certain limit)
nunomaduro
force-pushed
the
feat/browse-should
branch
from
f7f4d33
to
c307b41
Compare
nunomaduro
approved these changes
Jun 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposing
shouldStopallows people to create a different reason to stop browsing, e.g. if they only need the first 10.000 results instead of the whole index.see #991 for use case examples