Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(getLogs): enhance type with inner_queries #1109

Merged
merged 6 commits into from
Jun 8, 2020
Merged

feat(getLogs): enhance type with inner_queries #1109

merged 6 commits into from
Jun 8, 2020

Conversation

Haroenv
Copy link
Contributor

@Haroenv Haroenv commented Mar 27, 2020

Haroenv
Haroenv commented Mar 27, 2020
View reviewed changes
packages/client-search/src/types/Log.ts Outdated Show resolved Hide resolved
packages/client-search/src/types/Log.ts Outdated Show resolved Hide resolved
packages/client-search/src/types/Log.ts Outdated Show resolved Hide resolved
nunomaduro
nunomaduro suggested changes Mar 27, 2020
View reviewed changes
packages/client-search/src/types/Log.ts Outdated Show resolved Hide resolved
packages/client-search/src/types/Log.ts Outdated Show resolved Hide resolved
@nunomaduro
Copy link

@Haroenv Tests may not pass, as c1-test is dead.

@Ant-hem
Copy link
Member

Ant-hem commented Mar 27, 2020

@Haroenv Tests may not pass, as c1-test is dead.

c1-test is back to life!

@Haroenv Haroenv requested a review from nunomaduro April 21, 2020 12:30
nunomaduro
nunomaduro previously approved these changes Apr 21, 2020
View reviewed changes
Copy link

@nunomaduro nunomaduro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's sounds good. But let's don't merge it yet. And wait for some other pr in other clients to get started.

@nunomaduro nunomaduro merged commit 35ffb1f into master Jun 8, 2020
@nunomaduro nunomaduro deleted the Haroenv-patch-1 branch June 8, 2020 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ant-hem Ant-hem Ant-hem left review comments

@nunomaduro nunomaduro nunomaduro left review comments

Assignees
No one assigned
Labels
DO NOT MERGE YET
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(logs): add inner_queries response field
3 participants
@Haroenv @nunomaduro @Ant-hem