Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): Log types #1139

Merged
merged 2 commits into from
Apr 17, 2020
Merged

fix(types): Log types #1139

merged 2 commits into from
Apr 17, 2020

Conversation

chloelbn
Copy link

Related issue: #1137

This fixes the types of Log, as well as putting some field optionals

@nunomaduro
Copy link

Still not quite there looking at the tests:

    Expected: ArrayContaining ["timestamp", "method", "answer_code", "query_body", "answer", "url", "ip", "sha1", "query_headers", "nb_api_calls", "processing_time_ms"]
    Received: ["timestamp", "method", "answer_code", "query_body", "answer", "url", "ip", "query_headers", "sha1", "processing_time_ms", "index", "query_params"]

@nunomaduro
Copy link

The bundledize is failing, but we didn't touch on the source code. I will try to check this.

Copy link
Contributor

@Haroenv Haroenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bundlesize change is indeed unexpected, type change looks good!

Copy link
Contributor

@Haroenv Haroenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bundlesize is failing since af659f1, so not blocking this fix, however it's probably blocking release

@nunomaduro nunomaduro merged commit 61494e2 into master Apr 17, 2020
@nunomaduro nunomaduro deleted the fix/log-types branch April 17, 2020 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants