Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(requester-node-http): fix handling chunked responses fix #1161 #1164

Merged
merged 2 commits into from
Jun 9, 2020

Conversation

nunomaduro
Copy link

@nunomaduro nunomaduro commented Jun 9, 2020

Original pull request: #1162.
Fixes: #1161

Same pull request as the original one. Just added the readable stream dependency so this code can be tested in every node version.

@nunomaduro nunomaduro force-pushed the fix/node-requester-chunked-responses branch from 56c3f4f to 9ff4c13 Compare June 9, 2020 13:47
@nunomaduro nunomaduro merged commit 399d3f1 into master Jun 9, 2020
@nunomaduro nunomaduro deleted the fix/node-requester-chunked-responses branch June 9, 2020 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: unicode characters in responses are sometimes corrupted v4 (node)
3 participants