Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(search): add type for queryLanguages #1406

Merged
merged 2 commits into from
May 17, 2022
Merged

feat(search): add type for queryLanguages #1406

merged 2 commits into from
May 17, 2022

Conversation

Haroenv
Copy link
Contributor

@Haroenv Haroenv commented May 17, 2022

According to https://www.algolia.com/doc/api-reference/api-parameters/queryLanguages/?client=javascript, it can be sent as a search parameter too.

fixes #1405

@codesandbox-ci
Copy link

codesandbox-ci bot commented May 17, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 945c60f:

Sandbox Source
algolia/create-instantsearch-app Configuration

Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@Haroenv
Copy link
Contributor Author

Haroenv commented May 17, 2022

the test failures are unrelated, @shortcuts, will you follow up before release? they're required to pass before it can be released :)

@Haroenv Haroenv enabled auto-merge (squash) May 17, 2022 12:21
@Haroenv Haroenv merged commit 61c2976 into master May 17, 2022
@Haroenv Haroenv deleted the feat/ql-type branch May 17, 2022 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

queryLanguages not listed in SearchOptions
2 participants