Add get_task_status method to Algolia::Index class. #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…can get the status of a task without having to wait for it to finish.
…tributes get_task_status test.
3 similar comments
|
I have created an issue in case you guys don't want to go this way with adding the functionality to get a tasks status here #199 |
Awesome @srodman7689 👍 Thank you so much for contributing! |
redox
reviewed
Mar 17, 2017
spec/client_spec.rb
Outdated
| @@ -693,7 +693,7 @@ def wait_global_key_missing(key) | |||
|
|
|||
| it 'Check attributes get_task_status' do | |||
| task = @index.add_object!({ :name => "John Doe", :email => "john@doe.org" }, "1") | |||
| status = @index.get_task_status(task["taskID"]) | |||
| status = @index.get_task_status(task["objectID"]) | |||
There was a problem hiding this comment.
This was actually correct, we what to get the status of the taskID not the objectID.
…Check attributes get_task_status test." This reverts commit 19f1733.
|
Travis will fail because of the encrypted API keys we're using. I've run it locally 👍 |
1 similar comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After looking through the source of this library I realized that there wasn't a way to just check the status of a task instead of waiting for a task to finish. So I decided to create a pull request in the hopes that you guys would merge it and add this functionality. I could really use it.