Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: automatic crawler name #24

Merged
merged 8 commits into from
Jul 20, 2021
Merged

feat: automatic crawler name #24

merged 8 commits into from
Jul 20, 2021

Conversation

damcou
Copy link
Collaborator

@damcou damcou commented Jul 19, 2021

Set default crawler name related to repository and branch

@damcou damcou requested a review from bodinsamuel July 19, 2021 13:31
@netlify
Copy link

netlify bot commented Jul 19, 2021 •
edited
Loading

✔️ Deploy Preview for algolia-ga-actions-netlify ready!

🔨 Explore the source changes: 5d3984f

🔍 Inspect the deploy log: https://app.netlify.com/sites/algolia-ga-actions-netlify/deploys/60f6cf1101fce5000788b7da

😎 Browse the preview: https://deploy-preview-24--algolia-ga-actions-netlify.netlify.app

@damcou
Copy link
Collaborator Author

damcou commented Jul 19, 2021

Tested on https://github.com/damcou/simple-page/pull/5

@github-actions
Copy link

Check your created Crawler

Check your created index on your Algolia Application

bodinsamuel
bodinsamuel approved these changes Jul 19, 2021
View reviewed changes
Copy link
Contributor

@bodinsamuel bodinsamuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

action.yml Outdated Show resolved Hide resolved
@vercel
Copy link

vercel bot commented Jul 20, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/algolia-crawler/algoliasearch-crawler-github-actions/GvS8fBDwU4GCLnJKnZDm3aVuncGY
✅ Preview: https://algoliasearch-crawler-github-actions-git-94e593-algolia-crawler.vercel.app

@github-actions
Copy link

Check your created Crawler

Check your created index on your Algolia Application

@damcou damcou requested a review from bodinsamuel July 20, 2021 13:19
bodinsamuel
bodinsamuel reviewed Jul 20, 2021
View reviewed changes
Copy link
Contributor

@bodinsamuel bodinsamuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment; also the title of the PR should be updated ☺️

build/index.js Show resolved Hide resolved
@damcou damcou changed the title Feat/automatic crawler name feat: automatic crawler name Jul 20, 2021
@damcou damcou requested a review from bodinsamuel July 20, 2021 13:28
@damcou damcou merged commit d6861c2 into main Jul 20, 2021
@damcou damcou deleted the feat/automatic-crawler-name branch July 20, 2021 13:38
algolia-crawler-bot pushed a commit that referenced this pull request Jul 20, 2021
@semantic-release-bot
chore(release): 0.8.0 [skip ci]
a16ae19 
# [0.8.0](v0.7.3...v0.8.0) (2021-07-20)

### Features

* automatic crawler name ([#24](#24)) ([d6861c2](d6861c2))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bodinsamuel bodinsamuel Awaiting requested review from bodinsamuel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@damcou @bodinsamuel