Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add analytics feature #754

Merged
merged 1 commit into from
Feb 17, 2017
Merged

Add analytics feature #754

merged 1 commit into from
Feb 17, 2017

Conversation

JanPetr
Copy link
Contributor

@JanPetr JanPetr commented Feb 10, 2017

No description provided.

@JanPetr JanPetr requested a review from maxiloc February 10, 2017 15:17
@maxiloc
Copy link
Contributor

maxiloc commented Feb 10, 2017

Just to be sure, we are out of the box we GA if you enable it ?
And universal analytics handle all of them ?

@maxiloc
Copy link
Contributor

maxiloc commented Feb 10, 2017

Yep I saw that 😄 but is all analytics except google are using a ga variable ?

@JanPetr
Copy link
Contributor Author

JanPetr commented Feb 10, 2017

You can implement GA into a website in two ways. In a legacy way (using _gaq.push()) or like Universal Analytics (ga object).
Magento out-of-the-box supports both:
screenshot 2017-02-10 16 28 36

That's why I test both and use the right code for the one enabled.

If the owner of the website uses something different or want to use it in any other way, he can define his own push function .

@JanPetr JanPetr merged commit 46c74c2 into develop Feb 17, 2017
@JanPetr JanPetr deleted the add_analytics branch February 17, 2017 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants