-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Queue merge optimalization and delete operations optimalization #757
Conversation
4c38eb8
to
fde60b5
Compare
protected $by_page; | ||
protected $maxSingleJobDataSize; | ||
|
||
private $staticJobMethods = array( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we call that one static ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because those jobs cannot be reordered or merged
try { | ||
$this->db->beginTransaction(); | ||
|
||
while (true) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can probably avoid the while true
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
fde60b5
to
054a6c5
Compare
@JanPetr and how did you optimized deletion? We still have large amount of deletions (half of all of our operations) and most of our products are configurables... |
@JanPetr can we verify if the simple product, that has "not visible individually" is a part of configurable product. And if so, do not send "delete" operation? |
Hey @Mobecls, You can do that by modifying the extension, but I won't put it directly to the extension as there is a chance you will have indexed wrong data. |
@JanPetr yes, we have queue enabled. The logic is that not visible individually, which is part of configurable - should not be shown and won't be shown evern - nor on website, no on algolia. So there is no need to send delete's.... |
The issue is it might be indexed before becoming part of the configurable product. |
I was thinking of yes/no setting |
No description provided.