Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queue merge optimalization and delete operations optimalization #757

Merged
merged 3 commits into from
Feb 24, 2017

Conversation

JanPetr
Copy link
Contributor

@JanPetr JanPetr commented Feb 15, 2017

No description provided.

@JanPetr JanPetr requested a review from maxiloc February 15, 2017 15:21
@JanPetr JanPetr force-pushed the queue_and_delete_ops_optimalization branch 2 times, most recently from 4c38eb8 to fde60b5 Compare February 16, 2017 14:14
protected $by_page;
protected $maxSingleJobDataSize;

private $staticJobMethods = array(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we call that one static ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because those jobs cannot be reordered or merged

try {
$this->db->beginTransaction();

while (true) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can probably avoid the while true

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@JanPetr JanPetr force-pushed the queue_and_delete_ops_optimalization branch from fde60b5 to 054a6c5 Compare February 22, 2017 14:59
@JanPetr JanPetr merged commit d9920e0 into develop Feb 24, 2017
@JanPetr JanPetr deleted the queue_and_delete_ops_optimalization branch February 24, 2017 09:55
@Mobecls
Copy link

Mobecls commented Apr 6, 2017

@JanPetr and how did you optimized deletion? We still have large amount of deletions (half of all of our operations) and most of our products are configurables...

@Mobecls
Copy link

Mobecls commented Apr 6, 2017

@JanPetr can we verify if the simple product, that has "not visible individually" is a part of configurable product. And if so, do not send "delete" operation?

@JanPetr
Copy link
Contributor Author

JanPetr commented Apr 6, 2017

Hey @Mobecls,
do you have enabled indexing queue? The optimalization works best with queue enabled, when products are indexed by batches.

You can do that by modifying the extension, but I won't put it directly to the extension as there is a chance you will have indexed wrong data.

@Mobecls
Copy link

Mobecls commented Apr 6, 2017

@JanPetr yes, we have queue enabled.

The logic is that not visible individually, which is part of configurable - should not be shown and won't be shown evern - nor on website, no on algolia. So there is no need to send delete's....

@JanPetr
Copy link
Contributor Author

JanPetr commented Apr 6, 2017

The issue is it might be indexed before becoming part of the configurable product.

@Mobecls
Copy link

Mobecls commented Apr 6, 2017

I was thinking of yes/no setting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants