Rework of InstantSearch extensionality [BC break] #822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanPetr
changed the title
JanPetr
force-pushed
the
feat/reworked_IS_extensionality
branch
from
76b47f5
to
9f9e200
Compare
bobylito
reviewed
May 4, 2017
There was a problem hiding this comment.
It looks very good! I think you should provide some tooling to be able to fetch a specific widget config based on some predicate (attribute name or kind of widget) because otherwise it could be tedious to update.
Feel free to discard my comments if they don't fit with your coding style.
js/algoliasearch/instantsearch.js
Outdated
| allWidgetConfiguration = algoliaHookBeforeWidgetInitialization(allWidgetConfiguration); | ||
| } | ||
|
|
||
| for (var widgetType in allWidgetConfiguration) { |
There was a problem hiding this comment.
I'd reuse $.each here too.
js/algoliasearch/instantsearch.js
Outdated
|
|
||
| for (var widgetType in allWidgetConfiguration) { | ||
| if (Array.isArray(allWidgetConfiguration[widgetType]) === true) { | ||
| for (var i = 0; i < allWidgetConfiguration[widgetType].length; i++) { |
There was a problem hiding this comment.
I'd reuse $.each here too.
js/algoliasearch/instantsearch.js
Outdated
| addWidget(search, widgetType, widgetConfig); | ||
| } | ||
|
|
||
| continue; |
There was a problem hiding this comment.
I'd replace that with an else statement two lines after.
| var widgetType = widgetInfo[0], | ||
| widgetConfig = widgetInfo[1]; | ||
|
|
||
| if (typeof allWidgetConfiguration[widgetType] === 'undefined') { |
There was a problem hiding this comment.
I'd go for:
if (typeof allWidgetConfiguration[widgetType] === 'undefined') {
allWidgetConfiguration[widgetType] = [widgetConfig];
} else {
allWidgetConfiguration[widgetType].push(widgetConfig);
}
JanPetr
force-pushed
the
feat/reworked_IS_extensionality
branch
from
9f9e200
to
388de6a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #821