This repository has been archived by the owner on May 9, 2019. It is now read-only.
fix: decode HTML entities before sending them to Algolia #768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit will decode HTML entities for the post content attribute before sending it to Algolia. This ensures we do not end up displaying things like `&`. This issue arises now because we properly escape the content in the frontend directly. The solution is to store the decoded HTML in Algolia and let the frontend handle the escaping. In order to benefit from this fix, you should re-index everything. You can also choose to cherry pick and update the posts having an encoded char displayed. **Test plan:** The fix has manually been tested by adding `&` in the post editor. This would turn the symbol into `&` but stores it as `&` in Algolia. To be sure, I also tried to inject JS directly from adding script tags to an Algolia record. They are properly escaped at run time. Closes: #656
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit will decode HTML entities for the post content attribute before sending it to Algolia.
This ensures we do not end up displaying things like
&.This issue arises now because we properly escape the content in the frontend directly.
The solution is to store the decoded HTML in Algolia and let the frontend handle the escaping.
In order to benefit from this fix, you should re-index everything.
You can also choose to cherry pick and update the posts having an encoded char displayed.
Test plan:
The fix has manually been tested by adding
&in the post editor.This would turn the symbol into
&but stores it as&in Algolia.To be sure, I also tried to inject JS directly from adding script tags to an Algolia record.
They are properly escaped at run time.
Closes: #656