Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(specs): make DELETE endpoints return a 200 OK #1314

Merged
merged 1 commit into from
Feb 14, 2023

Conversation

Fluf22
Copy link
Contributor

@Fluf22 Fluf22 commented Feb 14, 2023

🧭 What and Why

🎟 JIRA Ticket: Related to DI-962

Changes included:

Replaced 204 No Content status code for all APIs DELETE endpoints by a 200 OK

Wait for https://github.com/algolia/data-ingestion/pull/1056 before merging

@Fluf22 Fluf22 requested a review from a team as a code owner February 14, 2023 13:20
@Fluf22 Fluf22 self-assigned this Feb 14, 2023
@netlify
Copy link

netlify bot commented Feb 14, 2023

Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit b6a30f7
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/63eb8a8e54a23e00089753a8
😎 Deploy Preview https://deploy-preview-1314--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Feb 14, 2023

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@Fluf22 Fluf22 requested review from millotp and removed request for shortcuts February 14, 2023 13:21
@Fluf22 Fluf22 merged commit f7f0fbe into main Feb 14, 2023
@Fluf22 Fluf22 deleted the fix/delete-item-return branch February 14, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants