Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(specs): add neuralSearch options #1474

Merged
merged 8 commits into from
Apr 19, 2023
Merged

feat(specs): add neuralSearch options #1474

merged 8 commits into from
Apr 19, 2023

Conversation

shortcuts
Copy link
Member

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/DI-1210

Changes included:

closes #1456

this PR implements the changes made on the JavaScript client to leverage the new NeuralSearch parameters.

@shortcuts shortcuts self-assigned this Apr 19, 2023
@netlify
Copy link

netlify bot commented Apr 19, 2023

Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit a02c2fb
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/643fe87483ecd900088098f9
😎 Deploy Preview https://deploy-preview-1474--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Apr 19, 2023

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@shortcuts shortcuts requested a review from millotp April 19, 2023 11:19
@shortcuts shortcuts requested a review from aallam April 19, 2023 13:53
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome !

@@ -108,6 +108,14 @@ baseSearchResponse:
type: string
description: A url-encoded string of all search parameters.
example: query=a&hitsPerPage=20
redirect:
type: object
description: This parameter is for internal use only.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want to expose something internal ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes because the client is used on the dashboard for internal purposes :/

@shortcuts shortcuts merged commit 13e7d17 into main Apr 19, 2023
@shortcuts shortcuts deleted the feat/neuralsearch branch April 19, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(specs): catch up with latest API clients changes
3 participants