feat(javascript): remove classes usage #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
millotp
reviewed
Feb 22, 2022
clients/algoliasearch-client-javascript/packages/client-common/src/errors.ts
Outdated
Show resolved
Hide resolved
clients/algoliasearch-client-javascript/packages/client-common/src/createStatefulHost.ts
Outdated
Show resolved
Hide resolved
We could make it clearer in future iteration, I did not wanted to introduce too many changes in this PR |
millotp
approved these changes
Feb 22, 2022
This was referenced Feb 23, 2022
This was referenced Feb 28, 2022
This was referenced Mar 22, 2022
shortcuts
added a commit
that referenced
this pull request
Apr 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: https://algolia.atlassian.net/browse/APIC-340
Changes included:
typesfile in atypesfolder, as it was getting hard to read it.There is no technical changes in this PR, mostly renaming and reformatting.
🧪 Test
CI :D