Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(specs): add new outlier count properties to variant payload #1656

Merged
merged 2 commits into from
Jun 26, 2023
Merged

feat(specs): add new outlier count properties to variant payload #1656

merged 2 commits into from
Jun 26, 2023

Conversation

febeck
Copy link
Contributor

@febeck febeck commented Jun 22, 2023 •
edited by jira bot
Loading

🧭 What and Why

Update generate clients to document the new added property in the variant payload following the changes in the API made
here https://github.com/algolia/go/pull/11313

🎟 JIRA Ticket: SCC-652

Changes included:

  • Add new outlierUsersCount and outlierTrackedSearchesCount properties to the Variant schema

🧪 Test

@netlify
Copy link

netlify bot commented Jun 22, 2023 •
edited
Loading

✅ Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit 6a7fc04
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/64996d5ac9aa070008360463
😎 Deploy Preview https://deploy-preview-1656--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Jun 22, 2023 •
edited
Loading

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@febeck febeck changed the title feat(abtests): add new outlier count properties to variant payload feat(specs): add new outlier count properties to variant payload Jun 22, 2023
@febeck febeck requested a review from cdhawke June 22, 2023 13:22
@febeck febeck force-pushed the feat/abtests/add_outliers_count_to_variants branch from 933173b to 6a7fc04 Compare June 26, 2023 10:50
@febeck febeck marked this pull request as ready for review June 26, 2023 10:50
@febeck febeck requested a review from a team as a code owner June 26, 2023 10:50
millotp
millotp approved these changes Jun 26, 2023
View reviewed changes
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good ! feel free to merge when you want, or tag me if you can't do it :)

@febeck
Copy link
Contributor Author

febeck commented Jun 26, 2023

@millotp I am unable to merge my PR, please feel free to do so when you have some time available

@shortcuts shortcuts merged commit b7c71de into main Jun 26, 2023
@shortcuts shortcuts deleted the feat/abtests/add_outliers_count_to_variants branch June 26, 2023 13:00
@febeck febeck mentioned this pull request Jun 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@millotp millotp millotp approved these changes

@cdhawke cdhawke Awaiting requested review from cdhawke

@aallam aallam Awaiting requested review from aallam aallam is a code owner automatically assigned from algolia/api-clients-automation

@mehmetaligok mehmetaligok Awaiting requested review from mehmetaligok mehmetaligok is a code owner automatically assigned from algolia/api-clients-automation

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@febeck @algolia-bot @millotp @shortcuts