fix(javascript): use babel plugin for classProperties #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually I should be able to copy the built file in csb and import it 🤔 |
|
Ok I've updated the sandbox with the new code and it works, so we good!! @eunjae-lee |
I'm still building locally 😂 but anyway it looks good to me. |
eunjae-lee
approved these changes
Mar 2, 2022
This was referenced Mar 22, 2022
shortcuts
added a commit
that referenced
this pull request
Apr 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: -
Changes included:
Fix https://codesandbox.io/s/bold-forest-jc82hd?file=/src/index.js, I was not able to reproduce locally so I'm testing it blindfolded.
The impact on the bundlesize is minimal, while the advantage of having this property are quite cool
browserentry, we don't have aliteversion yet🧪 Test
CI :D