Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(specs): import crawler and usage specs from new world repo #2598

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

shortcuts
Copy link
Member

🧭 What and Why

🎟 JIRA Ticket: -

Changes included:

This PR imports the crawler and usage specs written by @kai687 from the new worlds repository, this allows us to centralizes Algolia specs in a single place which all respect the same writing conventions etc.

@shortcuts shortcuts self-assigned this Jan 23, 2024
@shortcuts shortcuts requested a review from a team as a code owner January 23, 2024 08:54
Copy link

netlify bot commented Jan 23, 2024

Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit ecfa996
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/65af7ed382085f0008e1cf75
😎 Deploy Preview https://deploy-preview-2598--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Comment on lines -55 to -59
if (docMethod.summary) {
// Remove dot at the end of summary for better sidebar display
docMethod.summary = docMethod.summary.replace(/\.$/gm, '');
}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't need this anymore

@algolia-bot
Copy link
Collaborator

algolia-bot commented Jan 23, 2024

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@morganleroi
Copy link
Contributor

insane !

Copy link
Contributor

@Fluf22 Fluf22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see anything wrong!

@shortcuts shortcuts merged commit 982fd3c into main Jan 23, 2024
28 checks passed
@shortcuts shortcuts deleted the feat/specs-usage-and-crawler branch January 23, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants