Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(specs): a/b testing #2981

Merged
merged 17 commits into from
Apr 9, 2024
Merged

fix(specs): a/b testing #2981

merged 17 commits into from
Apr 9, 2024

Conversation

kai687
Copy link
Contributor

@kai687 kai687 commented Apr 8, 2024

🧭 What and Why

Update the A/B testing spec to improve the reference content.

Changes included:

  • The configuration object wasn't included yet
  • Status is an enum
  • Headers for rate-limiting info

@algolia-bot
Copy link
Collaborator

algolia-bot commented Apr 8, 2024

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@kai687 kai687 marked this pull request as ready for review April 8, 2024 17:25
@kai687 kai687 requested a review from a team as a code owner April 8, 2024 17:25
@kai687 kai687 requested review from damcou and Fluf22 April 8, 2024 17:25
@Fluf22
Copy link
Contributor

Fluf22 commented Apr 8, 2024

I pushed a fix for Swift: filenames need to be unique

Copy link

github-actions bot commented Apr 8, 2024

@github-actions github-actions bot temporarily deployed to pull request April 8, 2024 18:16 Inactive
Copy link
Contributor

@Fluf22 Fluf22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvements!
I'm curious to learn about x-additionalPropertiesName though 🤔

@kai687
Copy link
Contributor Author

kai687 commented Apr 8, 2024

Nice improvements! I'm curious to learn about x-additionalPropertiesName though 🤔

It's a vendor extension from redoc (for better documentation)

@shortcuts
Copy link
Member

Nice improvements! I'm curious to learn about x-additionalPropertiesName though 🤔

It's a vendor extension from redoc (for better documentation)

I don't think it's reflected on the doc atm, is it? 🤔

@kai687
Copy link
Contributor Author

kai687 commented Apr 9, 2024

@shortcuts it should. See revenueSignificance for the "Retrieve A/B test details" response.
It shows 'currency code'. Without it, it would show 'property name' (see the published version of the same endpoint).

2024-04-09_11-22-10

@shortcuts
Copy link
Member

@shortcuts it should. See revenueSignificance for the "Retrieve A/B test details" response. It shows 'currency code'. Without it, it would show 'property name' (see the published version of the same endpoint).

2024-04-09_11-22-10

ahhhh oki I see, that's super nice!

@shortcuts shortcuts enabled auto-merge (squash) April 9, 2024 09:33
@github-actions github-actions bot temporarily deployed to pull request April 9, 2024 12:15 Inactive
@shortcuts shortcuts merged commit 60322c0 into main Apr 9, 2024
25 checks passed
@shortcuts shortcuts deleted the docs/ab-testing branch April 9, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants