fix(javascript): handle parent in models #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shortcuts
requested review from
eunjae-lee and
damcou
and removed request for
a team
✅ Deploy Preview for api-clients-automation canceled.
|
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
eunjae-lee
reviewed
Apr 6, 2022
millotp
approved these changes
Apr 6, 2022
| @Override | ||
| public String getName() { | ||
| return "algolia-javascript"; | ||
| } | ||
|
|
||
| @Override | ||
| public CodegenOperation fromOperation(String path, String httpMethod, Operation operation, List<Server> servers) { | ||
| return Utils.specifyCustomRequest(super.fromOperation(path, httpMethod, operation, servers)); | ||
| public CodegenOperation fromOperation( |
There was a problem hiding this comment.
this made me realize we don't format the generators, I'll add a step in the CI.
There was a problem hiding this comment.
Yep true, I did not understood why it's not done so I've kept it for this file, good idea
algolia-bot
added a commit
to algolia/algoliasearch-client-javascript
that referenced
this pull request
Apr 6, 2022
algolia/api-clients-automation#339 Co-authored-by: Clément Vannicatte <20689156+shortcuts@users.noreply.github.com>
This was referenced Apr 11, 2022
shortcuts
added a commit
that referenced
this pull request
Apr 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: https://algolia.atlassian.net/browse/APIC-413
Changes included:
JavaScript types were not reflecting the
additionalPropertiesoption in our specs, which made some of our types incorrect.🧪 Test