fix(cts): add waitForTask helpers tests [skip-bc] #3618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✔️ Code generated!
📊 Benchmark resultsBenchmarks performed on the method using a mock server, the results might not reflect the real-world performance.
|
millotp
force-pushed
the
fix/helpers-tests
branch
from
0d8ae6e
to
3507854
Compare
millotp
changed the title
millotp
force-pushed
the
fix/helpers-tests
branch
3 times, most recently
from
91090b5
to
bbf8a84
Compare
millotp
requested review from
morganleroi and
Fluf22
and removed request for
a team
Fluf22
reviewed
Aug 30, 2024
millotp
force-pushed
the
fix/helpers-tests
branch
from
bbf8a84
to
ed4df05
Compare
millotp
changed the title
Fluf22
approved these changes
Sep 2, 2024
Comment on lines
+150
to
+152
| .option('-e, --no-e2e', 'skip the e2e tests, that requires internet connection') | ||
| .option('-c, --no-client', 'skip the client tests') | ||
| .option('-r, --no-requests', 'skip the requests tests') |
There was a problem hiding this comment.
😄😇 jk
Suggested change
| .option('-e, --no-e2e', 'skip the e2e tests, that requires internet connection') | |
| .option('-c, --no-client', 'skip the client tests') | |
| .option('-r, --no-requests', 'skip the requests tests') | |
| .option('-e, --skip-e2e', 'skip the e2e tests, that requires internet connection') | |
| .option('-c, --skip-client', 'skip the client tests') | |
| .option('-r, --skip-requests', 'skip the requests tests') |
There was a problem hiding this comment.
sorry that doesn't work ahah
shortcuts
approved these changes
Sep 2, 2024
| @@ -15,6 +15,9 @@ async function buildLanguage(language: Language, gens: Generator[], buildType: B | |||
| case 'csharp': | |||
| await run('dotnet build --configuration Release', { cwd, language }); | |||
| break; | |||
| case 'go': | |||
algolia-bot
added a commit
that referenced
this pull request
Sep 2, 2024
… [skip ci] Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-dart
that referenced
this pull request
Sep 2, 2024
algolia/api-clients-automation#3618 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-go
that referenced
this pull request
Sep 2, 2024
algolia/api-clients-automation#3618 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-java
that referenced
this pull request
Sep 2, 2024
algolia/api-clients-automation#3618 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-kotlin
that referenced
this pull request
Sep 2, 2024
algolia/api-clients-automation#3618 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-php
that referenced
this pull request
Sep 2, 2024
algolia/api-clients-automation#3618 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-scala
that referenced
this pull request
Sep 2, 2024
algolia/api-clients-automation#3618 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
Add all helpers to the spec and to the cts: