feat(specs): search advanced endpoints APIC-197 #40
Conversation
| method: | ||
| type: string | ||
| description: HTTP method of the perfomed request. | ||
| answer_code: |
There was a problem hiding this comment.
This is the first time seeing snake case in the API, this ruins everything
Co-authored-by: Pierre Millot <pierre.millot@algolia.com>
|
You need to generate the new java client also ( |
|
Ah ok 👌 |
| # /1/indexes/{indexName}/task/{taskID}: | ||
| # $ref: './paths/advanced/getTask.yml' | ||
| # /1/isalive: | ||
| # $ref: './paths/advanced/isAlive.yml' |
There was a problem hiding this comment.
I would still clarify this with search team, the goal of OpenApi is to reflect 1:1 the API not to reflect actual usage. If they don't want to document this endpoint fair enough, otherwise I would still keep it, at least in the spec
There was a problem hiding this comment.
To me the goal is to have consistent API Clients and an associated documentation of all the endpoints that we want to expose, not to list all weird legacy endpoints still replying 200.
But anyway for this one it has been clarified: https://docs.google.com/spreadsheets/d/1waVcU2Olr968Uni2rTM5N6NkUU3QY48kycfupBjZoBI/edit#gid=0
🧭 What and Why
🎟 JIRA Ticket: APIC-197
Changes included:
curlcall myself and looked in the csharp client and java client to list the properties (some of them seem wrong likeexhaustive)isaliveendpoint that doesn't exist in many clients and is not usefulyarn generate.gitignore(e.g.**/node_modulesis covered bynode_modules, see the OBSERVATION here: https://stackoverflow.com/a/38559600/1326281)