refactor(javascript): type setTimeout in a way compatible with node & browser #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for api-clients-automation ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
Haroenv
changed the title
shortcuts
reviewed
May 20, 2022
| @@ -54,7 +53,7 @@ export function createXhrRequester(): Requester { | |||
| // istanbul ignore next | |||
| if (baseRequester.status === 0) { | |||
| clearTimeout(connectTimeout); | |||
| clearTimeout(responseTimeout as NodeJS.Timeout); | |||
| clearTimeout(responseTimeout!); | |||
There was a problem hiding this comment.
Maybe a if to avoid having !?
There was a problem hiding this comment.
it's not actually needed, clearTimeout accepts null and undefined too, just type types don't allow that
algolia-bot
added a commit
to algolia/algoliasearch-client-javascript
that referenced
this pull request
May 23, 2022
… browser algolia/api-clients-automation#527 Co-authored-by: Haroen Viaene <hello@haroen.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
in node the output of setTimeout is NodeJS.Timeout, in browser it's number. This difference doesn't matter for us, and thus the return type can be used.
This allows us (if needed) to run the type checking with both node types enabled and disabled.
Changes included:
🧪 Test
TSC works