fix(javascript): clean rollup config #700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shortcuts
requested review from
damcou and
millotp
and removed request for
a team
✅ Deploy Preview for api-clients-automation canceled.
|
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
millotp
reviewed
Jun 15, 2022
| import fs from 'fs'; | ||
|
|
||
| // Org where the packages are pushed | ||
| const NPM_ORG = '@experimental-api-clients-automation/'; |
There was a problem hiding this comment.
maybe that value could be read from a package.json, should not be complicated if you want to do it
It's mostly splitting code in this one, there should not be perf changes but I'm doing some test to improve it and it was easier to navigate like that |
algolia-bot
added a commit
to algolia/algoliasearch-client-javascript
that referenced
this pull request
Jun 16, 2022
algolia/api-clients-automation#700 Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: -
Changes included:
I was experimenting some things to speed up the build process of the JS client and thought it was hard to navigate in the real part of the rollup config.
This PR split the concerns of the real rollup config and the package-related steps, there is no changes in the build itself.
🧪 Test
CI :D