Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(javascript): nest lite package in algoliasearch #729

Merged
merged 1 commit into from
Jun 22, 2022

Conversation

shortcuts
Copy link
Member

@shortcuts shortcuts commented Jun 21, 2022

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/APIC-546

Changes included:

This PR aims at removing the breaking change introduce when generating the lite package, there is a few motivations to that:

  • One less breaking change for users upgrading
  • Users can have a single package in their fullstack application
  • FX team can only require algoliasearch as a peer dependency

Benefits on our side:

  • One less client to build (included with algoliasearch)

Other changes in this PR:

  • Remove unused build (cjs.browser)
  • Default browser to umd
  • Add toBuild command to our CI
    • I first reworked a bit the CLI to do the magic, but there was too many unrelated changes in this PR so it will come later

🧪 Test

  • CI :D
  • Playgrounds

@netlify
Copy link

netlify bot commented Jun 21, 2022

Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit 653ccb0
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/62b318f7f0b84e0008bfa76a
😎 Deploy Preview https://deploy-preview-729--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Jun 21, 2022

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@shortcuts shortcuts force-pushed the feat/javascript-nested-algoliasearch-lite branch 5 times, most recently from c2fd93a to 773fa1d Compare June 22, 2022 08:12
@shortcuts shortcuts self-assigned this Jun 22, 2022
@shortcuts shortcuts force-pushed the feat/javascript-nested-algoliasearch-lite branch from 773fa1d to 254a961 Compare June 22, 2022 08:44
@shortcuts shortcuts requested review from a team, damcou and millotp and removed request for a team June 22, 2022 11:35
@shortcuts shortcuts marked this pull request as ready for review June 22, 2022 11:35
@Haroenv
Copy link
Contributor

Haroenv commented Jun 22, 2022

maybe it's just the preview, but the package algoliasearch-lite still exists in the generated branch

@shortcuts shortcuts force-pushed the feat/javascript-nested-algoliasearch-lite branch from 254a961 to 28b800a Compare June 22, 2022 13:26
@shortcuts
Copy link
Member Author

maybe it's just the preview, but the package algoliasearch-lite still exists in the generated branch

oops I should've removed it from here

@shortcuts shortcuts force-pushed the feat/javascript-nested-algoliasearch-lite branch from 28b800a to 653ccb0 Compare June 22, 2022 13:28
Copy link
Contributor

@damcou damcou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@shortcuts shortcuts merged commit 7ff32bf into main Jun 22, 2022
@shortcuts shortcuts deleted the feat/javascript-nested-algoliasearch-lite branch June 22, 2022 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants