feat(javascript): add abtesting client, better init usage
#784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for api-clients-automation ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
shortcuts
force-pushed
the
feat/js-algoliasearch-abtesting-dx
branch
from
c8f2e0a
to
4838a70
Compare
shortcuts
requested review from
a team,
damcou and
millotp
and removed request for
a team
shortcuts
force-pushed
the
feat/js-algoliasearch-abtesting-dx
branch
from
22269a9
to
58edaff
Compare
millotp
previously approved these changes
Jul 5, 2022
| }); | ||
| } | ||
|
|
||
| function initAbtesting(initOptions: CommonInitOptions & InitRegion<AbtestingRegion> = {}): AbtestingClient { |
There was a problem hiding this comment.
is there a way to make the Required<> or not correlated with the specs ? I guess it would be very hard
There was a problem hiding this comment.
We could leverage the hasFallback logic but since each init are unique it would be the same as having it hardcoded :/
damcou
previously approved these changes
Jul 5, 2022
millotp
approved these changes
Jul 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket:
Changes included:
The A/B Testing methods were previously available under the
analyticsclient, but are now under their own client, so we need to provide it inalgoliasearch.We now:
initAbtestingmethodinitmethods, already the case in v4, but we now also overriding.The size impact is quite big, which is not ideal but also not a big deal for the global
algoliasearchpackage.🧪 Test
CI :D