Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(javascript): rename predict package #796

Merged
merged 1 commit into from
Jul 6, 2022
Merged

Conversation

shortcuts
Copy link
Member

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/APIC-571

Changes included:

As predict is a different product than search, and in order to match what have been done for recommend, the package needs to be renamed.

There is no code change in this PR, only renaming.

🧪 Test

CI :D

@shortcuts shortcuts self-assigned this Jul 6, 2022
@netlify
Copy link

netlify bot commented Jul 6, 2022

Deploy Preview for api-clients-automation canceled.

Name Link
🔨 Latest commit b84c092
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/62c5a28ca5c4d70008f16219

@algolia-bot
Copy link
Collaborator

algolia-bot commented Jul 6, 2022

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

Base automatically changed from feat/use-algolia-namespace to main July 6, 2022 12:52
@shortcuts shortcuts force-pushed the feat/js-rename-package branch 2 times, most recently from 6cee2d4 to dbb3494 Compare July 6, 2022 14:39
@shortcuts shortcuts requested review from a team, damcou and millotp and removed request for a team July 6, 2022 15:08
@shortcuts shortcuts marked this pull request as ready for review July 6, 2022 15:08
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think some of those files like package.json could have been generated by the C, looks great anyway !

scripts/cts/runCts.ts Show resolved Hide resolved
@shortcuts shortcuts merged commit 0076edc into main Jul 6, 2022
@shortcuts shortcuts deleted the feat/js-rename-package branch July 6, 2022 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants