Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(specs): getApiKeyResponse, multipleBatch, partialUpdateObject #889

Merged
merged 4 commits into from
Aug 3, 2022
Merged

fix(specs): getApiKeyResponse, multipleBatch, partialUpdateObject #889

merged 4 commits into from
Aug 3, 2022

Conversation

shortcuts
Copy link
Member

@shortcuts shortcuts commented Aug 3, 2022 •
edited
Loading

🧭 What and Why

🎟 JIRA Ticket:

Changes included:

  • Fix some wrong types and missing parameter of the API key response.
  • Better name for the partialUpdateObject method parameter
  • Fix missing required properties of multipleBatch
  • Fix missing required requests of getObjects

🧪 Test

CI :D

@shortcuts shortcuts requested a review from damcou August 3, 2022 10:07
@shortcuts shortcuts self-assigned this Aug 3, 2022
@netlify
Copy link

netlify bot commented Aug 3, 2022 •
edited
Loading

✅ Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit e640cb9
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/62ea7d4a4455e80008a7a714
😎 Deploy Preview https://deploy-preview-889--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Aug 3, 2022 •
edited
Loading

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@shortcuts shortcuts force-pushed the fix/specs-keys-rules branch 3 times, most recently from 0c9b5ee to 0a4d244 Compare August 3, 2022 12:36
Base automatically changed from feat/js-iterable-promise to main August 3, 2022 12:53
@shortcuts shortcuts changed the title fix(specs): add missing parameter to getApiKeyResponse fix(specs): correct getApiKeyResponse, required properties of multipleBatch, fix partialUpdateObject naming Aug 3, 2022
@shortcuts shortcuts changed the title fix(specs): correct getApiKeyResponse, required properties of multipleBatch, fix partialUpdateObject naming fix(specs): getApiKeyResponse, multipleBatch, partialUpdateObject Aug 3, 2022
damcou
damcou approved these changes Aug 3, 2022
View reviewed changes
Copy link
Contributor

@damcou damcou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@shortcuts shortcuts merged commit 193fb73 into main Aug 3, 2022
@shortcuts shortcuts deleted the fix/specs-keys-rules branch August 3, 2022 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damcou damcou damcou approved these changes

Assignees

@shortcuts shortcuts

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shortcuts @algolia-bot @damcou