Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(javascript): expose clearCache and appId #892

Merged
merged 1 commit into from
Aug 3, 2022

Conversation

shortcuts
Copy link
Member

@shortcuts shortcuts commented Aug 3, 2022

🧭 What and Why

🎟 JIRA Ticket:

Changes included:

Those two properties were missing from the root of the client, which introduced unwanted breaking change.

Those properties were already present in v4, I've just imported it here.

🧪 Test

CI :D

@shortcuts shortcuts requested a review from damcou August 3, 2022 13:39
@shortcuts shortcuts self-assigned this Aug 3, 2022
@netlify
Copy link

netlify bot commented Aug 3, 2022

Deploy Preview for api-clients-automation canceled.

Name Link
🔨 Latest commit e69ff2d
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/62ea7aa204f97c000833f833

@shortcuts shortcuts enabled auto-merge (squash) August 3, 2022 13:39
@algolia-bot
Copy link
Collaborator

algolia-bot commented Aug 3, 2022

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

Copy link
Contributor

@damcou damcou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@shortcuts shortcuts merged commit fd3e226 into main Aug 3, 2022
@shortcuts shortcuts deleted the fix/js-exposed-properties branch August 3, 2022 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants