feat(dom): Add labels to buttons (#1234)

--------- Co-authored-by: Dishant Kapoor <dishant.kapoor@swspvtltd.com>
algolia · Feb 6, 2024 · 12d1596 · 12d1596
1 parent f03403d
commit 12d1596
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 0 deletions.
diff --git a/packages/autocomplete-js/src/createAutocompleteDom.ts b/packages/autocomplete-js/src/createAutocompleteDom.ts
@@ -161,6 +161,8 @@ export function createAutocompleteDom<TItem extends BaseItem>({
     const detachedSearchButton = createDomElement('button', {
       type: 'button',
       class: classNames.detachedSearchButton,
+      title: translations.detachedSearchButtonTitle,
+      id: labelProps.id,
       onClick() {
         setIsModalOpen(true);
       },

diff --git a/packages/autocomplete-js/src/getDefaultOptions.ts b/packages/autocomplete-js/src/getDefaultOptions.ts
@@ -138,6 +138,7 @@ export function getDefaultOptions<TItem extends BaseItem>(
   const defaultTranslations: AutocompleteTranslations = {
     clearButtonTitle: 'Clear',
     detachedCancelButtonText: 'Cancel',
+    detachedSearchButtonTitle: 'Search',
     submitButtonTitle: 'Submit',
   };
 

diff --git a/packages/autocomplete-shared/src/js/AutocompleteTranslations.ts b/packages/autocomplete-shared/src/js/AutocompleteTranslations.ts
@@ -2,4 +2,5 @@ export type AutocompleteTranslations = {
   detachedCancelButtonText: string;
   clearButtonTitle: string;
   submitButtonTitle: string;
+  detachedSearchButtonTitle: string;
 };