[DEX-258] feat/algolia index config import #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loicsay
force-pushed
the
feat/algolia-index-config-import
branch
from
750ff75
to
00bb685
Compare
loicsay
changed the title
loicsay
force-pushed
the
feat/algolia-index-config-import
branch
from
f347269
to
ebb5c0a
Compare
loicsay
force-pushed
the
feat/algolia-index-config-import
branch
from
ebb5c0a
to
4a41112
Compare
loicsay
force-pushed
the
feat/algolia-index-config-import
branch
from
4a41112
to
ae0ae1a
Compare
loicsay
commented
Oct 28, 2022
loicsay
force-pushed
the
feat/algolia-index-config-import
branch
4 times, most recently
from
2d9e79a
to
d9ce71b
Compare
loicsay
requested review from
clemfromspace
and removed request for
clemfromspace
loicsay
force-pushed
the
feat/algolia-index-config-import
branch
from
d9ce71b
to
42a609d
Compare
loicsay
commented
Nov 8, 2022
| @@ -0,0 +1,134 @@ | |||
| { | |||
There was a problem hiding this comment.
@clemfromspace
From what I understood, this will never be in the final build. However, I'm not sure this is the best practice to test that feature: wdyt?
There was a problem hiding this comment.
IMHO, it will be cleaner if you put this file under a sub-directoy like test_artifacts or something similar.
loicsay
force-pushed
the
feat/index-config-import-export
branch
from
601aeaa
to
a31dc0c
Compare
loicsay
force-pushed
the
feat/algolia-index-config-import
branch
from
01da3cf
to
1308cd2
Compare
clemfromspace
suggested changes
Nov 14, 2022
loicsay
force-pushed
the
feat/algolia-index-config-import
branch
from
fa129a3
to
e6b0711
Compare
clemfromspace
approved these changes
Nov 16, 2022
| @@ -0,0 +1,134 @@ | |||
| { | |||
There was a problem hiding this comment.
IMHO, it will be cleaner if you put this file under a sub-directoy like test_artifacts or something similar.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.