feat (api): Adds ability for click insights events to be triggered #1916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8bittitan
requested review from
shaneafsar,
clemfromspace,
levimichael,
loicsay and
dylantientcheu
✅ Deploy Preview for docsearch canceled.
|
levimichael
approved these changes
Jun 12, 2023
| item: InternalDocSearchHit, | ||
| itemPosition: number | ||
| ): InsightsParamsWithItems<ClickedObjectIDsAfterSearchParams> { | ||
| const insightsItem = item as AlgoliaInsightsHit; |
There was a problem hiding this comment.
Could we run into issues with this assertion?
There was a problem hiding this comment.
I don't think so, if we have an insights plugin active the needed attributes are added to the item. All AlgoliaInsightsHit type adds is better typings for the __autocomplete_* attributes.
shaneafsar
reviewed
Jun 13, 2023
shaneafsar
approved these changes
Jun 13, 2023
Co-authored-by: François Chalifour <francoischalifour@users.noreply.github.com>
francoischalifour
approved these changes
Jun 15, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently we added insights options for DocSearch in #1904. This PR now also adds in the ability for click analytics to be triggered as well when insights option is active.