feat(typescript): allow generic names starting with "K" #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We accept only generic type names starting with "T" but so
metimes, accepting "K" also makes sense. This is the case when
using the TypeScript keyword `keyof`:
```ts
type StateToWidgets = {
[KParameter in keyof IndexUiState]: Array<Widget['$$type']>;
};
```
See https://www.typescriptlang.org/docs/handbook/release-n
otes/typescript-2-1.html#example
Haroenv
approved these changes
Sep 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We accept only generic type names starting with "T" but sometimes, accepting "K" also makes sense. This is the case when using the TypeScript keyword
keyof:Related
keyoffeature: https://www.typescriptlang.org/docs/handbook/release-notes/typescript-2-1.html#example