fix(hierarchical): Hierarchical facets clearing (#252)

* fix issues with hierarchical facets clearing
algolia · Sep 27, 2022 · 3ba16f7 · 3ba16f7
1 parent 6862a7e
commit 3ba16f7
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/Sources/InstantSearchCore/FilterState/GroupStorage.swift b/Sources/InstantSearchCore/FilterState/GroupStorage.swift
@@ -147,7 +147,10 @@ extension GroupsStorage: FiltersWritable {
     for groupID in groupIDs {
       switch groupID {
       case .hierarchical:
-        filterGroups[groupID] = filterGroups[groupID]?.withFilters([])
+        if var cleanHierarchicalGroup = filterGroups[groupID]?.withFilters([]) as? FilterGroup.Hierarchical {
+          cleanHierarchicalGroup.hierarchicalFilters.removeAll()
+          filterGroups[groupID] = cleanHierarchicalGroup
+        }
       default:
         filterGroups.removeValue(forKey: groupID)
       }
@@ -182,7 +185,7 @@ extension GroupsStorage: FiltersWritable {
   }
 
   mutating func removeAll() {
-    filterGroups.removeAll()
+    removeAll(fromGroupWithIDs: Array(getGroupIDs()))
   }
 
 }

diff --git a/Sources/InstantSearchCore/Hierarchical/HierarchicalInteractor+FilterState.swift b/Sources/InstantSearchCore/Hierarchical/HierarchicalInteractor+FilterState.swift
@@ -39,8 +39,10 @@ public extension HierarchicalInteractor {
 
       }
 
-      filterState.onChange.subscribePast(with: interactor) { _, _ in
-        // TODO
+      filterState.onChange.subscribePast(with: interactor) { interactor, filterState in
+        if filterState[hierarchical: groupName].isEmpty {
+          interactor.selections = []
+        }
       }
 
     }