Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(searcher): Searchers refactoring #184

Merged
merged 45 commits into from
Nov 5, 2021
Merged

refactor(searcher): Searchers refactoring #184

merged 45 commits into from
Nov 5, 2021

Conversation

VladislavFitz
Copy link
Contributor

@VladislavFitz VladislavFitz commented Jul 30, 2021 •
edited
Loading

Summary

  • Rename SingleIndexSearcher to HitsSearcher
  • Introduce brand new MultiSearcher that can aggregate multiple HitsSearcher and FacetSearcher
  • Deprecate MultiIndexSearcher and related components

@VladislavFitz VladislavFitz changed the title refactor(searcher): SingleIndex & MultiIndexSearcher refactoring refactor(searcher): SearcherRefactoring Aug 12, 2021
@VladislavFitz VladislavFitz changed the title refactor(searcher): SearcherRefactoring refactor(searcher): Searchers refactoring Aug 12, 2021
@VladislavFitz VladislavFitz marked this pull request as draft August 12, 2021 12:56
@VladislavFitz
Copy link
Contributor Author

@aallam The PR is still no ready for review, but you can leave your comments and use it as a draft for the Android implementation.
The snippets describing the usage of the CompositeSearcher can be found here.

@VladislavFitz VladislavFitz marked this pull request as ready for review September 23, 2021 21:31
@VladislavFitz
add HitsSearcher example implementation
a69d092
@VladislavFitz
New composite searchers iteration
4649040
@VladislavFitz
improve sub-searchers attribution
1c2b5d1
@VladislavFitz
remove warnings
d8a34b3
@VladislavFitz
abstract enough composite searcher
065ce66
@VladislavFitz
adapt SingleIndexSearcher and FacetSearcher to use with CompositeSear…
b58de2f 
…cher
@VladislavFitz
Rename SingleIndexSearcher to HitsSearcher
3b5768d
@VladislavFitz
remove most of deprecation warnings
e56a770
@VladislavFitz
deprecated MultiIndexSearcher and related components and connections
e6dd85b
@VladislavFitz
Define connections between FilterState, QueryInputInteractor, SwitchI…
d30d7e3 
…ndexInteractor and all the searchers (Hits, Facet, Composite)
@VladislavFitz
simplify CompositeSearcher
5a1cbed
@VladislavFitz
fix lint issues
4e6141d
@VladislavFitz
implement subscriber connections
a747d4e
@VladislavFitz
refactor wip
d39e79b
@VladislavFitz
restore query input connector interface
e8a9364
@VladislavFitz
update query input interactor & connector
8355be6
@VladislavFitz
abstractcompositesearcher inherits from abstract searcher
195be74
@VladislavFitz
Update QueryInput and SwitchIndex documentation
8c60302
@VladislavFitz
update naming & comments of switch index
0e5aba0
@VladislavFitz
update generic type definitions
f5fbb12
@VladislavFitz
complete switch index components
f6e56e9
@VladislavFitz
Rename SingleIndexSearchConnector -> SearchConnector
13623c4
@VladislavFitz
update naming
9347af0
@VladislavFitz
improve composite search abstraction
13ed316
@VladislavFitz
Replace IndexSegmentInteractor with SortByInteractor
8fa65fb
@VladislavFitz
decouple SortBy from HitsSearcher
30ac342
@VladislavFitz
Rename Composite -> Multi
8f946c2
@VladislavFitz
fix lint issues
c8927b1
@VladislavFitz
rename AbstractMultiSearcher -> MultiSearcher
f0aa0ba
@VladislavFitz
rename CompoundSearchResponse -> MultiSearchResponse, update SortBySn…
eea77fa 
…ippets
@VladislavFitz
restore HitsConnector initializer with implicit interactor
6385510
@VladislavFitz
Separate MultiSearcher and AbstractMultiSearcher
e02ca84
@VladislavFitz
update SortBy connector code documentation
ee46f69
@VladislavFitz
post-review update
d05aef3
@VladislavFitz
fix searcher parameter label
32233fc
@VladislavFitz
remove generic searcher from SortByConnector
292ce62
@VladislavFitz
remove SwitchIndexObservableController
0fb839d
@VladislavFitz VladislavFitz merged commit 9e85b7c into master Nov 5, 2021
@VladislavFitz VladislavFitz deleted the refactor/searchers branch January 26, 2022 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aallam aallam aallam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VladislavFitz @aallam