Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(logging): Logging logic #248

Merged
merged 11 commits into from
Aug 25, 2022
Merged

refactor(logging): Logging logic #248

merged 11 commits into from
Aug 25, 2022

Conversation

VladislavFitz
Copy link
Contributor

@VladislavFitz VladislavFitz commented Aug 22, 2022 •
edited
Loading

Summary

This PR simplifies the logging functionality in the library.

  • Each target has an internal Log structure with its own instance of Logger
  • Logs is a public structure exposing the static logSeverityLevel property to a library user. It emits the notification with log severity level to notifiy all internal Log structures.

Fix #245

@VladislavFitz VladislavFitz changed the title refactor: Logging logic refactor(logging): Logging logic Aug 22, 2022
@VladislavFitz VladislavFitz marked this pull request as ready for review August 22, 2022 14:35
aallam
aallam approved these changes Aug 25, 2022
View reviewed changes
Copy link
Member

@aallam aallam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@VladislavFitz VladislavFitz merged commit 25d5e3e into master Aug 25, 2022
@VladislavFitz VladislavFitz deleted the refactor/logging branch October 17, 2022 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aallam aallam aallam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Not able to set log level
2 participants
@VladislavFitz @aallam